Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll Engine from 9b3e3410f026 to f10f17257300 (1 revision) #61194

Conversation

engine-flutter-autoroll
Copy link
Contributor

flutter/engine@9b3e341...f10f172

2020-07-09 ferhat@gmail.com [web] Update SurfacePath to use PathRef (flutter/engine#19557)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

@skia-gold
Copy link

Gold has detected about 28 untriaged digest(s) on patchset 1. View them at https://flutter-gold.skia.org/cl/github/61194

@fluttergithubbot
Copy link
Contributor

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

Changes to golden files are considered breaking changes, so consult Handling Breaking Changes to proceed. While there are exceptions to this rule, if this patch modifies an existing golden file, it is probably not an exception. Only new golden file tests, or downstream changes like those from skia updates are considered non-breaking.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #61194 at sha afe2cfb

@fluttergithubbot fluttergithubbot added c: API break Backwards-incompatible API changes will affect goldens Changes to golden files labels Jul 9, 2020
@fluttergithubbot fluttergithubbot merged commit a1097ea into flutter:master Jul 13, 2020
@engine-flutter-autoroll engine-flutter-autoroll deleted the flutter-engine-flutter-autoroll-55f212f1-92f7-4587-b2c7-c4fda1203b24-1594333265 branch July 16, 2020 23:05
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: API break Backwards-incompatible API changes will affect goldens Changes to golden files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants