Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ListTile] adds new properties to customize the tile color #61347

Merged
merged 3 commits into from Jul 14, 2020
Merged

[ListTile] adds new properties to customize the tile color #61347

merged 3 commits into from Jul 14, 2020

Conversation

AyushBherwani1998
Copy link
Member

Description

Adds two new properties, tileColor and selectedTileColor respectively to change the tile color of ListTile.

Usage

  • ListTile.selected is true.
ListTile(
  selected: true,
  selectedTileColor: Colors.brown,
  tileColor: Colors.black,
  title: const Text(
    'Title',
     style: TextStyle(color: Colors.orange),
   ),
)

tile_color_when_selected_is_true

  • ListTile.selected is false.
ListTile(
  selected: false,
  selectedTileColor: Colors.brown,
  tileColor: Colors.black,
  title: const Text(
    'Title',
     style: TextStyle(color: Colors.orange),
   ),
)

tile_color_when_selected_is_false

Related Issues

#33392

Tests

I added the following tests:

  • Added test to check that ListTile respects tileColor and selectedTileColor.
  • Added test to check the default tile color of ListTile.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 13, 2020
@shihaohong shihaohong changed the title [ListTile] adds new properties to customzie the tile color [ListTile] adds new properties to customize the tile color Jul 14, 2020
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code nits, otherwise the implementation and the tests look good

packages/flutter/lib/src/material/list_tile.dart Outdated Show resolved Hide resolved
packages/flutter/test/material/list_tile_test.dart Outdated Show resolved Hide resolved
packages/flutter/test/material/list_tile_test.dart Outdated Show resolved Hide resolved
@shihaohong shihaohong self-assigned this Jul 14, 2020
@shihaohong shihaohong added the c: new feature Nothing broken; request for a new capability label Jul 14, 2020
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakyoism
Copy link

kakyoism commented Jul 26, 2020

Is this available in other channels like dev?

Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: new feature Nothing broken; request for a new capability f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants