Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement customizable cursor height #61714

Merged
merged 8 commits into from Jul 21, 2020
Merged

Implement customizable cursor height #61714

merged 8 commits into from Jul 21, 2020

Commits on Jul 17, 2020

  1. Add cursorHeight wherever cursorWidth exists

    @guidezpl
    guidezpl committed Jul 17, 2020
    Copy the full SHA
    c77a145 View commit details
    Browse the repository at this point in the history

  2. Implement RenderEditable.cursorHeight

    @guidezpl
    guidezpl committed Jul 17, 2020
    Copy the full SHA
    5164de9 View commit details
    Browse the repository at this point in the history

  3. Add golden test for Material text field cursor height

    @guidezpl
    guidezpl committed Jul 17, 2020
    Copy the full SHA
    d3cceb9 View commit details
    Browse the repository at this point in the history

  4. Add golden test for EditableText cursor height

    @guidezpl
    guidezpl committed Jul 17, 2020
    Copy the full SHA
    c87e45a View commit details
    Browse the repository at this point in the history

  5. Update tests

    @guidezpl
    guidezpl committed Jul 17, 2020
    Copy the full SHA
    5c81dfd View commit details
    Browse the repository at this point in the history

  6. Fix typo

    @guidezpl
    guidezpl committed Jul 17, 2020
    Copy the full SHA
    c072b98 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. Update editable_text_cursor_test.dart

    @guidezpl
    guidezpl committed Jul 20, 2020
    Copy the full SHA
    85ae4d0 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. Remove extraneous pumps and add comment explaining 600ms

    @guidezpl
    guidezpl committed Jul 21, 2020
    Copy the full SHA
    da6b300 View commit details
    Browse the repository at this point in the history