Use OverflowBar instead of ButtonBar in TimePicker #62601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
f: material design
rami-a
approved these changes
Jul 30, 2020
| await tester.tap(find.text('OK')); | ||
| await tester.pumpAndSettle(); | ||
| }); | ||
|
|
||
| // TODO(rami-a): Re-enable and fix test. |
There was a problem hiding this comment.
Oops, looks like I forgot to remove a TODO, do you think you could remove it as part of this PR? Looks like the formatting of that test is a bit off too.
| child: Text(widget.confirmText ?? localizations.okButtonLabel), | ||
| ), | ||
| ], | ||
| child: Container( |
There was a problem hiding this comment.
Will this result in any visual diff from the ButtonBar?
There was a problem hiding this comment.
I don't think so. I've already done some image diffs before and after this PR, to check. Still need to check the test repo ofcourse.
This was referenced Jul 31, 2020
HansMuller
force-pushed
the
replace_button_bar_in_time_picker
branch
from
f209173
to
2a350e1
Compare
|
This pull request is not suitable for automatic merging in its current state.
|
Pragya007
pushed a commit
to Pragya007/flutter
that referenced
this pull request
Aug 11, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed TimePicker's dependency on ButtonBar, which has its own troublesome dependencies on ButtonTheme (now obsolete - see flutter.dev/go/material-button-system-updates) as well as a problematic implementation, see #53378.
This change is similar to #62686