New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove back button when using end drawer #63272
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
@gusghrlrl101 thanks for the contribution. Sorry for the delay in review. To be honest, I am not sure exactly what you are trying to solve with this. What is wrong with the back button showing when you are using a drawer from the right side? I looked at the spec, but I didn't see any guidance on this (other than to not use end drawers for navigation 😄 ). Even if the user sees the back arrow it in the darkened scrim on the left, if they tap on it, it will dismiss the drawer anyway, so I don't see the harm in having it there. Is there a use case for this that I am missing? All that said, if we decide to do this, your fix looks good. However, if we do proceed, we will need to have a test added that covers this change (see |
@darrenaustin, Thanks for your reply 😊. I added test code for I think it is unnecessary to show the button and it is awkward for user. Thank you 😊. |
@darrenaustin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the lag on this.
I am still not entirely convinced this is that necessary, but it does look like a reasonable implementation and people have been reporting it, so let's go with it.
LGTM. I will push this after they cut a new branch for release (which should be happening soon).
Thanks for the contribution!
@darrenaustin |
Would have been great if there was a boolean to disable and enable this new feature, this new behavior broke my app... this new change should not be the default. |
@drdDavi so sorry this broke your app. Can you give us more information on how exactly it did that? How were users even tapping the icon with the drawer open? |
@darrenaustin Before this back button and end drawer button both appeared. But now with 1.22.x, only end drawer button is shown. |
Description
Before
When
end drawer
opens,close button
is showing onleading
.After
When
end drawer
opens,close button
is not shown.Related Issues
#13601
Tests
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.