New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[61154] Fixed : Change the default width & height in dialog #64460
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @mkw8263 welcome! Can you add a test to verify the expected behavior? This will also help us make sure we don't undo it in the future. :)
I think I broke the code rule, so I will close it and send the PR again. |
PR agin |
Description
InsetPadding not working correctly in AlertDialog / Dialog
Despite EdgeInsets.all(0.0),
horizontal still has a padding value
solution -> BoxConstraints minWidth
Related Issues
#61154
Tests
None
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].