Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[61154] Fixed : Change the default width & height in dialog #64460

Closed
wants to merge 6 commits into from

Conversation

mkw8263
Copy link

@mkw8263 mkw8263 commented Aug 24, 2020

Description

InsetPadding not working correctly in AlertDialog / Dialog

 _showDialog() {
    showDialog(
      context: context,
      builder: (_) {
        return AlertDialog(
          insetPadding: EdgeInsets.all(0.0),
          content: Center(child: Text('asd')),
        );
      },
    );
  }

Despite EdgeInsets.all(0.0), horizontal still has a padding value

solution -> BoxConstraints minWidth

Related Issues

#61154

Tests

None

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 24, 2020
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@mkw8263 mkw8263 changed the title fix : Change the default width & height in dialog [61154] fix : Change the default width & height in dialog Aug 24, 2020
@mkw8263 mkw8263 changed the title [61154] fix : Change the default width & height in dialog [61154] Fixed : Change the default width & height in dialog Aug 24, 2020
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @mkw8263 welcome! Can you add a test to verify the expected behavior? This will also help us make sure we don't undo it in the future. :)

@mkw8263
Copy link
Author

mkw8263 commented Aug 30, 2020

I think I broke the code rule, so I will close it and send the PR again.

@mkw8263 mkw8263 closed this Aug 30, 2020
@mkw8263 mkw8263 deleted the padding-dialog branch August 30, 2020 13:28
@mkw8263
Copy link
Author

mkw8263 commented Aug 30, 2020

#64900

PR agin

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants