New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hintColor value for Material #65036
Update hintColor value for Material #65036
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Gold has detected about 6 untriaged digest(s) on patchset 1. |
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Hi @Piinks, this is my first time making golden file changes, so I might have not fully understood about Golden File Test. I ran
so I'm a bit confused about what should I do next with updated images... |
Hey @JuYeong0413! You can just include the image in your PR description above. :)
|
Ah, now I've got it. Thanks a lot @Piinks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated this change is covered by golden file tests.
Thank you fort he contribution @JuYeong0413 ! LGTM!
Description
Updated
hintColor
value for Material.Both Dark mode documentation and Light mode documentation states that
This pull request updates
hintColor
value in dark mode toColors.white60
(corresponds to 60% opacity).For light mode, updates value to
Colors.black.withOpacity(0.6)
since there's no constant for black60.For golden file changes:
Related Issues
Fixes #55329
Tests
None. Only color values changed.
If I need to add a test for this, please let me know. :)
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.