Improve pageStorage behavior #66634
Closed
Improve pageStorage behavior #66634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
framework
|
Why can you not just use different PageStroage for the scrollable widgets? |
|
For this case, the right thing to do is to use different keys. Using the depth is also problematic when widgets are moved in the widget tree (e.g. via GlobalKeys). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
PageStroagebehavior weird and not developer-friendly when multiple scrollable widgets share only one [PageStorageKey]. See also #62332A Solution
They are distinguished by adding depth information to the page storage identifier, and their data can be stored separately without interfering with each other
Related Issues
Fixes #62332
#63656
Tests
See files.