Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ListTile assert when layout at zero size #66798

Merged
merged 2 commits into from Oct 12, 2020

Conversation

xu-baolin
Copy link
Member

@xu-baolin xu-baolin commented Sep 28, 2020

Description

when minimizing the window the screen size will change to zero and will trigger layout at zero size.

Another issue, why the minimized window will trigger the screen size to zero. Track here #65061

Related Issues

Fixes #66636

Tests

I added the following tests:

See files.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Sep 28, 2020
@shihaohong shihaohong self-assigned this Oct 12, 2020
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@shihaohong shihaohong merged commit 8211aaa into flutter:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListTile throws exception in windows when resizing or hot restart
3 participants