Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert args to 0.13.6 #6765

Merged
merged 3 commits into from
Nov 8, 2016
Merged

revert args to 0.13.6 #6765

merged 3 commits into from
Nov 8, 2016

Conversation

danrubel
Copy link
Contributor

@danrubel danrubel commented Nov 8, 2016

args package v0.13.6+1 breaks flutter tools because the CommandRunner.runCommand no longer returns the value from executing command.run() (see line 188). This workaround rolls back to using args package v0.13.6 until an appropriate fix is made.

Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Hixie
Copy link
Contributor

Hixie commented Nov 8, 2016

This isn't enough, we have to pin it in any other packages that depend on it (see Travis build output).

@danrubel
Copy link
Contributor Author

danrubel commented Nov 8, 2016

Fixed.

@danrubel danrubel merged commit 6331b6c into flutter:master Nov 8, 2016
@Hixie
Copy link
Contributor

Hixie commented Nov 8, 2016

I'm surprised we have to pin it in quite so many packages. How are we ending up with random flutter apps depending on args, for example?

@danrubel danrubel deleted the fix-flutter-tools branch November 8, 2016 22:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants