[Material] Use primary color for selected rows and checkboxes in DataTable #67919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
|
The white on green in the dark theme checkbox is hard to discern. Is there an option to change the check mark color to something darker when the background color is brighter? |
clocksmith
approved these changes
Oct 12, 2020
I agree that the white color on green is a bit hard to see, but currently there is no theme for Checkboxes: flutter.dev/go/material-theme-system-updates Related issue: #53420 |
JoseAlba
approved these changes
Oct 12, 2020
| return (Theme.of(context)!.brightness == Brightness.light) ? | ||
| _grey100Opacity : _grey300Opacity; | ||
| } | ||
| if (states.contains(MaterialState.selected)) |
There was a problem hiding this comment.
nit: you can change this into a ternary operator
boolean ? exp1 : exp2
perclasson
requested review from
HansMuller
and removed request for
HansMuller
perclasson
changed the title
clocksmith
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Light Theme
According to Material specs we should use the 8% overlay color (https://material.io/design/interaction/states.html#selected) for selected states:
Dark Theme
In a dark theme, states should use the same overlay values as their default (or light) theme (https://material.io/design/color/dark-theme.html#states).
Screenshots
Related Issues
Closes #64314
Tests
I added the following tests:
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.