Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nullOk parameter from Router.of and make it return a non-nullable value #68910

Merged
merged 1 commit into from Oct 29, 2020
Merged

Remove nullOk parameter from Router.of and make it return a non-nullable value #68910

merged 1 commit into from Oct 29, 2020

Conversation

gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Oct 23, 2020 •
edited

Description

This removes the nullOk parameter from Router.of, and createsRouter.maybeOf. Router.ofnow returns a non-nullable value, and the Router.maybeOf returns a nullable value.

Related Issues

Tests

  • Updated tests to use maybeOf.

Breaking Change

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. work in progress; do not review labels Oct 23, 2020
@google-cla google-cla bot added the cla: yes label Oct 23, 2020
@gspencergoog gspencergoog marked this pull request as ready for review October 27, 2020 22:54
@gspencergoog gspencergoog changed the title Remove nullOk parameter from Router.of and make non-nullable. Remove nullOk parameter from Router.of and make it return a non-nullable value Oct 28, 2020
chunhtai
chunhtai approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gspencergoog gspencergoog merged commit 85a2525 into flutter:master Oct 29, 2020
@gspencergoog gspencergoog deleted the remove_null_ok_4 branch October 29, 2020 21:00
@rydmike rydmike mentioned this pull request Jan 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gspencergoog @chunhtai