Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nullOk parameter from Focus.of, FocusTraversalOrder.of, and FocusTraversalGroup.of #68917

Merged
merged 1 commit into from Oct 29, 2020
Merged

Remove nullOk parameter from Focus.of, FocusTraversalOrder.of, and FocusTraversalGroup.of #68917

merged 1 commit into from Oct 29, 2020

Conversation

gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Oct 23, 2020 •
edited

Description

This removes the nullOk parameter from Focus.of, FocusTraversalOrder.of and FocusTraversalGroup.of, and creates maybeOf equivalents for each. The of methods now return non-nullable values, and the maybeOf equivalents return nullable values.

Related Issues

Tests

  • Updated tests to not need ! anymore.

Breaking Change

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. work in progress; do not review labels Oct 23, 2020
@google-cla google-cla bot added the cla: yes label Oct 23, 2020
@gspencergoog gspencergoog marked this pull request as ready for review October 27, 2020 22:55
@gspencergoog gspencergoog force-pushed the remove_null_ok_6 branch 2 times, most recently from ec72f66 to e2207e3 Compare October 28, 2020 20:20
@gspencergoog gspencergoog requested review from darrenaustin and goderbauer and removed request for darrenaustin October 28, 2020 20:20
goderbauer
goderbauer approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/widgets/focus_scope.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/widgets/focus_scope.dart Outdated Show resolved Hide resolved
@gspencergoog gspencergoog merged commit fa3d2e2 into flutter:master Oct 29, 2020
@gspencergoog gspencergoog deleted the remove_null_ok_6 branch October 29, 2020 21:02
@rydmike rydmike mentioned this pull request Jan 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gspencergoog @goderbauer