Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "Updated SearchDelegate to follow custom InputDecorationTheme" #69653

Merged

Conversation

darrenaustin
Copy link
Contributor

Description

This is a relanding of #55209 which was reverted due to some internal test failures. These have been resolved on the internal side and we should be good to go.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 3, 2020
@google-cla google-cla bot added the cla: yes label Nov 3, 2020
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you'll need to make the analyzer happy

packages/flutter/lib/src/material/search.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/material/search.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/material/search.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/material/search.dart Outdated Show resolved Hide resolved
@darrenaustin
Copy link
Contributor Author

There were still some internal failures being reported, but appeared to be unrelated null safety issues that were caused by the roll being behind. I went ahead and marked it as a success so we can land this.

@fluttergithubbot fluttergithubbot merged commit 4c1d015 into flutter:master Nov 6, 2020
@darrenaustin darrenaustin deleted the search_delegate_reland branch April 26, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants