Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in RenderChip.computeMaxIntrinsicWidth implementation #69812

Merged

Conversation

LongCatIsLooong
Copy link
Contributor

Description

vertical -> horizontal

Related Issues

Fixes #49478

Tests

I added the following tests:

intrinsicHeight implementation meets constraints

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 4, 2020
@google-cla google-cla bot added the cla: yes label Nov 4, 2020
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Thanks for finding that!

@LongCatIsLooong LongCatIsLooong changed the title fix typo in computeMaxIntrinsicWidth implementation fix typo in RenderChip.computeMaxIntrinsicWidth implementation Nov 4, 2020
@fluttergithubbot fluttergithubbot merged commit 3197229 into flutter:master Nov 5, 2020
@LongCatIsLooong LongCatIsLooong deleted the chip-min-intrinsicheight branch November 5, 2020 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
3 participants