Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove add-to-app Xcode build phase input files #69846

Merged
merged 1 commit into from Nov 5, 2020
Merged

Remove add-to-app Xcode build phase input files #69846

merged 1 commit into from Nov 5, 2020

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Nov 5, 2020

Description

Remove the input files in the add-to-app CocoaPods build script to always run the Flutter script.
Screen Shot 2020-11-04 at 5 53 32 PM

  1. As of Build App.framework directly to build directory #69699 App.framework isn't written to .ios/Flutter
  2. App.framework should have been listed as an output, not an input.
  3. This probably doesn't run the script when it should, like when you switch from a real device to a simulator.
  4. There's already logic in the flutter tool to not recompile the dart app when nothing changes.

Related Issues

Follow up to #69699

@jmagman jmagman self-assigned this Nov 5, 2020
@flutter-dashboard flutter-dashboard bot added tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Nov 5, 2020
@jmagman jmagman added the a: existing-apps Integration with existing apps via the add-to-app flow label Nov 5, 2020
@google-cla google-cla bot added the cla: yes label Nov 5, 2020
@jmagman jmagman added t: xcode "xcodebuild" on iOS and general Xcode project management and removed cla: yes labels Nov 5, 2020
@google-cla google-cla bot added the cla: yes label Nov 5, 2020
@jmagman jmagman marked this pull request as ready for review November 5, 2020 04:31
@jmagman jmagman requested a review from xster November 5, 2020 04:31
@xster
Copy link
Member

xster commented Nov 5, 2020

Cool neat. LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@jmagman jmagman merged commit 58ba70a into flutter:master Nov 5, 2020
@jmagman jmagman deleted the a2a-input-files branch November 5, 2020 07:27
@jmagman jmagman mentioned this pull request Jan 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xster xster xster approved these changes

Assignees

@jmagman jmagman

Labels
a: existing-apps Integration with existing apps via the add-to-app flow t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmagman @xster @fluttergithubbot