Include null in the type that UpdateUrlFetcher's Future returns #70324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
team
renyou
approved these changes
Nov 11, 2020
|
This pull request is not suitable for automatic merging in its current state.
|
angjieli
pushed a commit
to angjieli/flutter1
that referenced
this pull request
Nov 13, 2020
angjieli
added a commit
that referenced
this pull request
Nov 13, 2020
* Future can return null (#70324) * Revert usages of the binding's platformDispatcher to use window instead (#70319) This reverts usages of the binding's platformDispatcher to use window again temporarily, because there isn't a TestPlatformDispatcher yet, and so some tests were failing because they mocked the TestWindow to return certain things (locales) that were returning the real values instead of the test values. Once I've created a TestPlatformDispatcher to allow fake data to be passed to it, we can go back to using the platformDispatcher in all of these places * Revert "mark catalina ios tasks as flaky (#70255)" (#70328) Co-authored-by: Emmanuel Garcia <egarciad@google.com> Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com> Co-authored-by: keyonghan <54558023+keyonghan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the analyzer in g3.