Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add casts to widgets_test.dart to fix the engine roll. #70423

Merged
merged 1 commit into from Nov 13, 2020

Conversation

gspencergoog
Copy link
Contributor

Description

Because of the timing of landing some changes, this fixes the engine roll so that some changes to the return value of window.locales and window.locale won't break the engine roll (as in this failure)

@flutter-dashboard flutter-dashboard bot added the a: internationalization Supporting other languages or locales. (aka i18n) label Nov 13, 2020
@google-cla google-cla bot added the cla: yes label Nov 13, 2020
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 9860f52 into flutter:master Nov 13, 2020
@gspencergoog gspencergoog deleted the fix_locale_test branch October 7, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: internationalization Supporting other languages or locales. (aka i18n)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants