Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ios_host_app Podfile search paths #71525

Merged
merged 1 commit into from Dec 2, 2020
Merged

ios_host_app Podfile search paths #71525

merged 1 commit into from Dec 2, 2020
+3 −6

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Dec 2, 2020

Description

FlutterUITests should be not be enclosed in the app target.

On CocoaPods 1.9.3, module_test_ios failed in conjunction with XCFramework adoption.

[module_test_ios] [STDOUT] stderr: Testing failed:
[module_test_ios] [STDOUT] stderr: 	Multiple commands produce '/Users/chrome-bot/Library/Developer/Xcode/DerivedData/Host-awwbtvmasrdobpfhghyvdjlbrers/Build/Products/Debug-iphonesimulator/cocoapods-artifacts-Debug.txt':
[module_test_ios] [STDOUT] stderr: 1) That command depends on command in Target 'FlutterUITests' (project 'Host'): script phase “[CP] Prepare Artifacts”
[module_test_ios] [STDOUT] stderr: 2) That command depends on command in Target 'Host' (project 'Host'): script phase “[CP] Prepare Artifacts”

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8862075951229786736/+/steps/run_module_test_ios/0/stdout

Move the test target out.

Related Issues

#71495
CocoaPods/CocoaPods#9670 (comment)

Tests

Tested by module_test_ios.

@jmagman jmagman added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. platform-ios iOS applications specifically labels Dec 2, 2020
@jmagman jmagman self-assigned this Dec 2, 2020
@google-cla google-cla bot added the cla: yes label Dec 2, 2020
@jmagman jmagman mentioned this pull request Dec 2, 2020
Merged
jmagman
jmagman commented Dec 2, 2020
View reviewed changes
dev/integration_tests/ios_host_app/Host.xcodeproj/project.pbxproj
@@ -566,7 +566,6 @@
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_TEAM = S8QB4VV633;
INFOPLIST_FILE = FlutterUITests/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 14.0;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be specified, it can inherit.

@jmagman jmagman requested a review from xster December 2, 2020 02:45
@jmagman
Copy link
Member Author

jmagman commented Dec 2, 2020

customer_testing-linux is failing due to flutter/tests#70.

@jmagman jmagman merged commit 60bdcf5 into flutter:master Dec 2, 2020
@jmagman jmagman deleted the host-app-search-paths branch December 2, 2020 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xster xster xster approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

@jmagman jmagman

Labels
platform-ios iOS applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmagman @xster