Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cupertino icons mapping which was misaligned by 1 #72384

Merged
merged 2 commits into from Dec 16, 2020
Merged

Fix cupertino icons mapping which was misaligned by 1 #72384

merged 2 commits into from Dec 16, 2020

Conversation

xster
Copy link
Member

@xster xster commented Dec 15, 2020 •
edited

Fixes #72237.
Fixes #69994.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Dec 15, 2020
@google-cla google-cla bot added the cla: yes label Dec 15, 2020
@xster xster mentioned this pull request Dec 15, 2020
Closed
@xster xster requested a review from guidezpl December 15, 2020 22:53
guidezpl
guidezpl approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

Can the corresponding test be reenabled?

@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Dec 15, 2020
@xster
Copy link
Member Author

xster commented Dec 15, 2020

Ha there was a race :)
Double checked locally that the test would have caught it. The NNBD issue seems to have been fixed now. Re-enabling.

@xster xster mentioned this pull request Dec 15, 2020
Closed
@xster xster merged commit 795b23e into flutter:master Dec 16, 2020
@xster xster deleted the cupertino-icons-mapping branch December 16, 2020 00:21
pcsosinski pushed a commit to pcsosinski/flutter that referenced this pull request Jan 14, 2021
@xster
Fix cupertino icons mapping which was misaligned by 1 (flutter#72384)
1fa8fce
pcsosinski pushed a commit that referenced this pull request Jan 14, 2021
@YeungKC @xster @jmagman
[flutter_releases] Flutter 1.25.0-8.3.pre framework cherrypicks (#73985)
5d36f2e 
* Update engine hash to 1.25.0-8.3.pre

* Fix dateAndTime and time modes of CupertinoDatePicker. (#73276)

* Fix cupertino icons mapping which was misaligned by 1 (#72384)

* Add recommended Xcode version to doctor (#73808)

* Remove unnecessary Xcode version check

Co-authored-by: YeungKC <I@YeungKC.com>
Co-authored-by: xster <xster@google.com>
Co-authored-by: Jenn Magder <magder@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees
No one assigned
Labels
f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
2 participants
@xster @guidezpl