Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated [PointerEnterEvent, PointerExitEvent].fromHoverEvent #72395

Merged
merged 3 commits into from Dec 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 23 additions & 0 deletions packages/flutter/lib/fix_data.yaml
Expand Up @@ -11,6 +11,29 @@
version: 1
transforms:

# Changes made in https://github.com/flutter/flutter/pull/28602
- title: 'Rename to fromMouseEvent'
date: 2020-12-15
element:
uris: [ 'gestures.dart' ]
constructor: 'fromHoverEvent'
inClass: 'PointerEnterEvent'
changes:
- kind: 'rename'
newName: 'fromMouseEvent'

# Changes made in https://github.com/flutter/flutter/pull/28602
- title: 'Rename to fromMouseEvent'
date: 2020-12-15
element:
uris: [ 'gestures.dart' ]
constructor: 'fromHoverEvent'
inClass: 'PointerExitEvent'
changes:
- kind: 'rename'
newName: 'fromMouseEvent'


# Changes made in https://github.com/flutter/flutter/pull/41859
- title: 'Remove brightness'
date: 2020-12-10
Expand Down
18 changes: 0 additions & 18 deletions packages/flutter/lib/src/gestures/events.dart
Expand Up @@ -1222,15 +1222,6 @@ class PointerEnterEvent extends PointerEvent with _PointerEventDescription, _Cop
embedderId: embedderId,
);

/// Creates an enter event from a [PointerHoverEvent].
///
/// Deprecated. Please use [PointerEnterEvent.fromMouseEvent] instead.
@Deprecated(
'Use PointerEnterEvent.fromMouseEvent instead. '
'This feature was deprecated after v1.4.3.'
)
factory PointerEnterEvent.fromHoverEvent(PointerHoverEvent event) => PointerEnterEvent.fromMouseEvent(event);

/// Creates an enter event from a [PointerEvent].
///
/// This is used by the [MouseTracker] to synthesize enter events.
Expand Down Expand Up @@ -1397,15 +1388,6 @@ class PointerExitEvent extends PointerEvent with _PointerEventDescription, _Copy
embedderId: embedderId,
);

/// Creates an enter event from a [PointerHoverEvent].
///
/// Deprecated. Please use [PointerExitEvent.fromMouseEvent] instead.
@Deprecated(
'Use PointerExitEvent.fromMouseEvent instead. '
'This feature was deprecated after v1.4.3.'
)
factory PointerExitEvent.fromHoverEvent(PointerHoverEvent event) => PointerExitEvent.fromMouseEvent(event);

/// Creates an exit event from a [PointerEvent].
///
/// This is used by the [MouseTracker] to synthesize exit events.
Expand Down
13 changes: 13 additions & 0 deletions packages/flutter/test_fixes/gestures.dart
@@ -0,0 +1,13 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter/gestures.dart';

void main() {
// Change made in https://github.com/flutter/flutter/pull/28602
final PointerEnterEvent enterEvent = PointerEnterEvent.fromHoverEvent(PointerHoverEvent());

// Change made in https://github.com/flutter/flutter/pull/28602
final PointerExitEvent exitEvent = PointerExitEvent.fromHoverEvent(PointerHoverEvent());
}
13 changes: 13 additions & 0 deletions packages/flutter/test_fixes/gestures.dart.expect
@@ -0,0 +1,13 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter/gestures.dart';

void main() {
// Change made in https://github.com/flutter/flutter/pull/28602
final PointerEnterEvent enterEvent = PointerEnterEvent.fromMouseEvent(PointerHoverEvent());

// Change made in https://github.com/flutter/flutter/pull/28602
final PointerExitEvent exitEvent = PointerExitEvent.fromMouseEvent(PointerHoverEvent());
}