Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Launch named iOS simulators" #72447

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Revert "Launch named iOS simulators" #72447

merged 1 commit into from
Dec 16, 2020

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Dec 16, 2020

Reverts #72323

@DanTup says this caused a regression #72323 (comment):

Looks like the platformType in the daemon response from emulator.getEmulators (docs) isn't right. It should be "ios" but is coming through as "iOS-14-3".

We compare that string to the output of daemon.getSupportedPlatforms to know which devices/emulators are valid for the current project, so this means none of them are showing up right now.

@jmagman jmagman requested a review from xster December 16, 2020 17:45
@jmagman jmagman self-assigned this Dec 16, 2020
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 16, 2020
@google-cla google-cla bot added the cla: yes label Dec 16, 2020
@jmagman jmagman requested a review from DanTup December 16, 2020 19:44
DanTup
DanTup approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@DanTup DanTup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@jmagman jmagman merged commit cdacae8 into master Dec 16, 2020
@jmagman jmagman deleted the revert-72323-simulator branch December 16, 2020 19:53
@DanTup
Copy link
Contributor

DanTup commented Dec 16, 2020

@jmagman if you make a fix for this and want me to do any testing before you land (I can pull from your fork), let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanTup DanTup DanTup approved these changes

@xster xster Awaiting requested review from xster

Assignees

@jmagman jmagman

Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmagman @DanTup