Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Cupertino docs #72927

Merged
merged 16 commits into from Jan 4, 2021
Merged

Improve Cupertino docs #72927

merged 16 commits into from Jan 4, 2021

Conversation

guidezpl
Copy link
Member

@guidezpl guidezpl commented Dec 24, 2020 •
edited

Description

Adds "See also" section to cupertino library
Adds 3 snippets for CupertinoApp (2 with screenshots require flutter/assets-for-api-docs#129 to merge first)
Adds a dartpad for CupertinoNavigationBar
Adds a dartpad for CupertinoPageScaffold

Related Issues

#72926

Tests

No tests, only documentation.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Dec 24, 2020
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Dec 24, 2020
@guidezpl guidezpl mentioned this pull request Dec 24, 2020
Merged
@guidezpl guidezpl requested a review from xster December 24, 2020 15:14
shihaohong
shihaohong approved these changes Dec 26, 2020
View reviewed changes
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits and once the assets-for-api-docs change is merged.

packages/flutter/lib/src/cupertino/app.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/cupertino/nav_bar.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/cupertino/page_scaffold.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/cupertino/page_scaffold.dart Show resolved Hide resolved
guidezpl and others added 3 commits December 29, 2020 11:06
@guidezpl
Fix capitalization
f2b4f0a 
Co-authored-by: Shi-Hao Hong <shihaohong@google.com>
@guidezpl
Apply suggestions from code review
2dfed5d 
Co-authored-by: Shi-Hao Hong <shihaohong@google.com>
@guidezpl
Add comment about backgroundColor
962e9fe
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux flutter_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.

@guidezpl guidezpl merged commit 47e3e75 into flutter:master Jan 4, 2021
@guidezpl guidezpl deleted the cupertino-samples branch January 4, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shihaohong shihaohong shihaohong approved these changes

@xster xster Awaiting requested review from xster

Assignees
No one assigned
Labels
f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guidezpl @fluttergithubbot @shihaohong