Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document TableRowInkWell and DataTable interactions better #73018

Merged
merged 4 commits into from Jan 23, 2021

Conversation

shihaohong
Copy link
Contributor

Description

Addresses #72879

Tests

I added the following tests:

  • Documentation, no tests.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Dec 28, 2020
@google-cla google-cla bot added the cla: yes label Dec 28, 2020
@shihaohong shihaohong changed the title Document TableRowInkWell and DataTable interactions better. Document TableRowInkWell and DataTable interactions better Dec 28, 2020
@shihaohong shihaohong added the d: api docs Issues with https://api.flutter.dev/ label Dec 28, 2020
@flutter-dashboard
Copy link

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits! :)

packages/flutter/lib/src/material/data_table.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/material/data_table.dart Outdated Show resolved Hide resolved
@Piinks
Copy link
Contributor

Piinks commented Jan 22, 2021

CI is a bit cranky, but it looks unrelated to this change.

Shi-Hao Hong and others added 2 commits January 23, 2021 03:22
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: Kate Lovett <katelovett@google.com>
@fluttergithubbot fluttergithubbot merged commit 3f37d86 into flutter:master Jan 23, 2021
@shihaohong shihaohong deleted the doc-update branch April 19, 2021 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants