Removed the color field from AppBarTheme #73732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
darrenaustin
approved these changes
Jan 11, 2021
| }); | ||
| }) : assert( | ||
| color == null || backgroundColor == null, | ||
| 'The color and backgroundColor parameters mean the same thing. Only specify one.'), |
There was a problem hiding this comment.
Perhaps '...parameters are used to describe the same thing.'
| @@ -29,8 +29,8 @@ class AppBarTheme with Diagnosticable { | |||
| /// Creates a theme that can be used for [ThemeData.appBarTheme]. | |||
| const AppBarTheme({ | |||
| this.brightness, | |||
| this.color, | |||
| this.backgroundColor, | |||
| Color? color, | |||
There was a problem hiding this comment.
Do we want to mark this as deprecated?
There was a problem hiding this comment.
I'm going to update some existing use cases first. After that this (and a few other parameters) will definitely be deprecated.
HansMuller
force-pushed
the
remove_appbar_theme_color_field
branch
from
6839c54
to
c9e5aa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old color and the new backgroundColor field mean the same thing. The backgroundColor field was added in #71184 for the sake of consistency with AppBar.backgroundColor, however the original color field was not removed. It's now gone and there's an assert for the error of specifying both.