Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore adaptive nature to new Scrollbar #73899

Merged
merged 4 commits into from Jan 14, 2021

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Jan 13, 2021

This PR makes the Scrollbar widget adaptive again.
A large refactoring was completed in #71664, which temporarily disabled the adaptive behavior of the Scrollbar widget. This brings that ability back, in a cleaner way by making the Scrollbar widget a wrapper class. The new Material Design scroll bar is in _MaterialScrollbar, keeping it separate from the CupertinoScrollbar.

The adaptability tests that were removed in #71664 have been restored. Added a todo to update the CupertinoScrollbar for desktop behavior.

Part of #70866

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Jan 13, 2021
@flutter-dashboard flutter-dashboard bot added the f: material design flutter/packages/flutter/material repository. label Jan 13, 2021
@google-cla google-cla bot added the cla: yes label Jan 13, 2021
packages/flutter/lib/src/material/scrollbar.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/material/scrollbar.dart Outdated Show resolved Hide resolved
packages/flutter/test/material/scrollbar_test.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/material/scrollbar.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/material/scrollbar.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

Copy link

@AMH8790 AMH8790 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mahmas501gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants