New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore adaptive nature to new Scrollbar #73899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
added
framework
flutter/packages/flutter repository. See also f: labels.
f: scrolling
Viewports, list views, slivers, etc.
labels
Jan 13, 2021
flutter-dashboard
bot
added
the
f: material design
flutter/packages/flutter/material repository.
label
Jan 13, 2021
HansMuller
reviewed
Jan 13, 2021
HansMuller
reviewed
Jan 14, 2021
HansMuller
approved these changes
Jan 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request is not suitable for automatic merging in its current state.
|
This was referenced Jan 16, 2021
AMH8790
reviewed
Feb 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mahmas501gmail.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
f: material design
flutter/packages/flutter/material repository.
f: scrolling
Viewports, list views, slivers, etc.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
Scrollbar
widget adaptive again.A large refactoring was completed in #71664, which temporarily disabled the adaptive behavior of the
Scrollbar
widget. This brings that ability back, in a cleaner way by making theScrollbar
widget a wrapper class. The new Material Design scroll bar is in _MaterialScrollbar, keeping it separate from the CupertinoScrollbar.The adaptability tests that were removed in #71664 have been restored. Added a todo to update the
CupertinoScrollbar
for desktop behavior.Part of #70866
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.