New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_releases] Roll pub for flutter-1.26-candidate.17 #75733
[flutter_releases] Roll pub for flutter-1.26-candidate.17 #75733
Conversation
…packages we want to roll
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - would appreciate a LGTM from a Dart ecosystem person to validate that these versions are the right ones too though
|
This is the upstream fix: c100544 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@christopherfujino Some of these got messed up, sadly:
args and convert should get dropped then |
A release branch specific recreation of #75370.
To create this PR, I applied branch-specific updates to
packages/flutter_tools/lib/src/commands/update_packages.dart
:transitiveDepsAllowlist
that allows pinning transitive deps (upstream, pinning transitive deps could lead to situations where version resolution fails).flutter update-packages --force-upgrade
.