Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_releases] Roll pub for flutter-1.26-candidate.17 #75733

Conversation

christopherfujino
Copy link
Member

@christopherfujino christopherfujino commented Feb 9, 2021

A release branch specific recreation of #75370.

To create this PR, I applied branch-specific updates to packages/flutter_tools/lib/src/commands/update_packages.dart:

  1. Removing the pins from the "Dart team owned nnbd deps"
  2. Pinning any unrelated packages that would be upgraded
  3. Created a special transitiveDepsAllowlist that allows pinning transitive deps (upstream, pinning transitive deps could lead to situations where version resolution fails).
  4. Then ran flutter update-packages --force-upgrade.
  5. Fix tools integration test by applying c100544

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Feb 9, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Feb 9, 2021
@christopherfujino christopherfujino requested review from jakemac53 and dnfield and removed request for Piinks February 9, 2021 21:42
@christopherfujino christopherfujino changed the title Roll pub flutter 1.26 candidate.17 Roll pub for flutter-1.26-candidate.17 Feb 9, 2021
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - would appreciate a LGTM from a Dart ecosystem person to validate that these versions are the right ones too though

@christopherfujino christopherfujino changed the title Roll pub for flutter-1.26-candidate.17 [flutter_releases] Roll pub for flutter-1.26-candidate.17 Feb 9, 2021
@christopherfujino
Copy link
Member Author

Linux tool_integration_tests is failing because pub get resolving failed for an integration test. investigating now.

@christopherfujino
Copy link
Member Author

Linux tool_integration_tests is failing because pub get resolving failed for an integration test. investigating now.

This is the upstream fix: c100544

Copy link
Contributor

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@christopherfujino christopherfujino merged commit 7158702 into flutter:flutter-1.26-candidate.17 Feb 10, 2021
@christopherfujino christopherfujino deleted the roll-pub-flutter-1.26-candidate.17 branch February 10, 2021 00:26
@kevmoo
Copy link
Contributor

kevmoo commented Feb 10, 2021

@christopherfujino Some of these got messed up, sadly:

  • archive should be at 3.0.0
  • crypto should be an 3.0.0
  • platform: 3.0.0
  • process: 3.0.0
  • sync_http 0.3.0
  • webdriver: 3.0.0
  • vm_service: 6.0.1-nullsafety.1
  • file: 6.0.0

args and convert should get dropped then

@pcsosinski pcsosinski mentioned this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants