Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Buttons with icon RenderFlex overflow #78018

Merged
merged 1 commit into from Mar 17, 2021
Merged

Fixed Buttons with icon RenderFlex overflow #78018

merged 1 commit into from Mar 17, 2021

Conversation

lsaudon
Copy link
Contributor

@lsaudon lsaudon commented Mar 12, 2021

Fixed Buttons with icon RenderFlex overflow

Before

image

After

image

#77815

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 12, 2021
@google-cla google-cla bot added the cla: yes label Mar 12, 2021
@HansMuller HansMuller self-requested a review March 16, 2021 21:39
HansMuller
HansMuller approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! LGTM

@HansMuller HansMuller merged commit e260a73 into flutter:master Mar 17, 2021
HansMuller pushed a commit that referenced this pull request Mar 23, 2021
Revert "Fixed Buttons with icon RenderFlex overflow (#78018)"
fae1ba0 
This reverts commit e260a73.
@HansMuller HansMuller mentioned this pull request Mar 23, 2021
Merged
fluttergithubbot pushed a commit that referenced this pull request Mar 23, 2021
@HansMuller
Revert "Fixed Buttons with icon RenderFlex overflow (#78018)" (#78825)
720dac5
@HansMuller HansMuller mentioned this pull request Mar 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lsaudon @HansMuller