Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved AssetImage Docs #78173

Merged
merged 9 commits into from
May 17, 2021
Merged

Improved AssetImage Docs #78173

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d475746
improved AssetImage docs
Swayam221 Mar 14, 2021
01d02a1
pointed to image provider
Swayam221 Mar 25, 2021
a7d1769
Adjust according to flutter style
Swayam221 Mar 27, 2021
d6bb944
removed unnecessary whitespaces
Swayam221 Mar 31, 2021
07ecc5b
Merge remote-tracking branch 'upstream/master' into assetimagedocs
Swayam221 Apr 5, 2021
bed0fd2
added sample code
Swayam221 May 5, 2021
22103a0
removed traiking spaces
Swayam221 May 5, 2021
d69ed76
Merge remote-tracking branch 'upstream/master' into assetimagedocs
Swayam221 May 12, 2021
5a4626b
fixed warning
Swayam221 May 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/flutter/lib/src/painting/image_resolution.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,9 @@ const double _kLowDprLimit = 2.0;
/// ```dart
/// AssetImage('icons/heart.png')
/// ```
///
///
/// To understand how an [Image] object is made out of an [AssetImage], refer [ImageProvider] and [AssetBundleImageProvider].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to adjust the Engilsh here for grammar and to fit the Flutter style, something more like:

/// For an example of resolving an [AssetImage] to obtain a [dart:ui.Image] object,
/// refer to the sample code in the documentation for [ImageProvider].

///
/// ## Assets in packages
///
/// To fetch an asset from a package, the [package] argument must be provided.
Expand Down