Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly position the built-in drag handles on horizontal ReorderableListViews. #79484

Merged
merged 1 commit into from Mar 31, 2021
Merged

Properly position the built-in drag handles on horizontal ReorderableListViews. #79484

merged 1 commit into from Mar 31, 2021

Conversation

darrenaustin
Copy link
Contributor

The positioning of the drag handles in ReorderableListView is incorrect for horizontal lists. This PR moves them to the correct location.

Fixes: #79453

Added tests to verify the position of the drag handle for both vertical and horizontal lists.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 31, 2021
@google-cla google-cla bot added the cla: yes label Mar 31, 2021
HansMuller
HansMuller approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darrenaustin darrenaustin merged commit 722a085 into flutter:master Mar 31, 2021
@idkq
Copy link

idkq commented Apr 16, 2021 •
edited

@darrenaustin Is this related maybe?

#80553

@darrenaustin darrenaustin deleted the reorderable_horiz branch April 26, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drag icon of ReorderableListView is badly placed when scroll direction is horizontal
3 participants
@darrenaustin @idkq @HansMuller