Add BackdropFilter blend mode #80129
Conversation
flutter-dashboard
bot
added
the
framework
|
Gold has detected about 1 untriaged digest(s) on patchset 2. |
flar
force-pushed
the
add-backdropfilter-blend-mode
branch
from
725ba72
to
27a208c
Compare
|
I fixed a minor discrepancy I noticed in the BackdropFilterLayer class - markNeedsAddToScene should only be called if the value changes. |
|
Gold has detected about 1 untriaged digest(s) on patchset 3. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. Changes reported for pull request #80129 at sha ccd62850adfc9234f1673a0edd7b8852a417a545 |
|
@ferhatb one of the golden images showed the blend mode not applying like the others. It's listed as Chrome on Linux, but there is no indication of whether it is using the DOM or the CanvasKit renderer. I'm assuming that it is the DOM renderer, but since the results don't really convey this, it is hard to click on "Approve" here. Is there a way we can factor the renderer into the results so that we can be more certain of the conditions under which we are approving the golden images? |
|
With input from @yjbanov on Discord, I've approved the last golden change. It is the expected output from the HTML renderer (until HTML standards support this property). |
|
I think I've pushed changes for all of the feedback, let me know if I missed something. |
flar
force-pushed
the
add-backdropfilter-blend-mode
branch
from
8e6e922
to
a9e9d47
Compare
flar
force-pushed
the
add-backdropfilter-blend-mode
branch
from
0c4d50f
to
08e27e9
Compare
|
I believe I have resolved the outstanding issues. @goderbauer ? |
This PR is the framework half of flutter/engine#19631 which provides a way to control the blending of the BackdropFilter filter output onto the scene important for cases where the widget is inside of another parent widget that uses a saveLayer - most typically an Opacity widget.
I'd be particularly interested in hearing from @ferhatb as to whether the caveats about using this feature with the DOM renderer are appropriately worded (and in particular, how should we canonically refer to that platform?).