Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dynamic by Object/Object? in router.dart #80476

Merged
merged 1 commit into from Apr 17, 2021
Merged

Replace dynamic by Object/Object? in router.dart #80476

merged 1 commit into from Apr 17, 2021

Conversation

aminedakhlii
Copy link
Contributor

Closes #77357

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 15, 2021
@google-cla google-cla bot added the cla: yes label Apr 15, 2021
@aminedakhlii
Copy link
Contributor Author

@goderbauer I messed things up while re-basing in the previous PR so here is a new cleaner one, could you review it?

@Hixie
Copy link
Contributor

Hixie commented Apr 16, 2021

test-exempt: code refactor with no semantic change.

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai
Copy link
Contributor

@aminedakhlii The test failure looks unrelated, can you try rebase off the latest master branch?

replace dynamic by Object/Object? in router.dart

replace dynamic by Object/Object? in router.dart
@aminedakhlii
Copy link
Contributor Author

@chunhtai done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace dynamic by Object or Object? in router.dart file
4 participants