Convert AnimatedSize to a StatefulWidget #80554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
framework
goderbauer
approved these changes
Apr 16, 2021
| this.alignment = Alignment.center, | ||
| this.curve = Curves.linear, | ||
| required this.duration, | ||
| this.reverseDuration, | ||
| required this.vsync, | ||
| @Deprecated('Ignored') TickerProvider? vsync, |
There was a problem hiding this comment.
nit: these deprecation notices need to follow a certain pattern, see "Breaking Changes" in the wiki.
| @@ -49,21 +50,23 @@ import 'framework.dart'; | |||
| /// See also: | |||
| /// | |||
| /// * [SizeTransition], which changes its size based on an [Animation]. | |||
| class AnimatedSize extends SingleChildRenderObjectWidget { | |||
| /// Creates a widget that animates its size to match that of its child. | |||
There was a problem hiding this comment.
keep some doc on the constructor?
| } | ||
|
|
||
| class _AnimatedSize extends SingleChildRenderObjectWidget { | ||
| /// Creates a widget that animates its size to match that of its child. |
There was a problem hiding this comment.
this doc can probably be removed since the constructor is private and this doesn't contain much information...
jason-simmons
force-pushed
the
animated_size_leak_2
branch
2 times, most recently
from
259bcf7
to
ca76263
Compare
jason-simmons
added a commit
to jason-simmons/flutter_gallery
that referenced
this pull request
Apr 20, 2021
This is needed in order to land flutter/flutter#80554, which will deprecate AnimatedSize.vsync
jason-simmons
added a commit
to jason-simmons/rainbowmonkey
that referenced
this pull request
Apr 20, 2021
This is needed in order to land flutter/flutter#80554, which will deprecate AnimatedSize.vsync
jason-simmons
force-pushed
the
animated_size_leak_2
branch
from
ca76263
to
6d29469
Compare
|
Removed the
PTAL @goderbauer |
jason-simmons
added a commit
to jason-simmons/flutter_gallery
that referenced
this pull request
Apr 21, 2021
This is needed in order to land flutter/flutter#80554, which will deprecate AnimatedSize.vsync
jason-simmons
force-pushed
the
animated_size_leak_2
branch
from
6d29469
to
b44fa03
Compare
goderbauer
approved these changes
Apr 21, 2021
| this.alignment = Alignment.center, | ||
| this.curve = Curves.linear, | ||
| required this.duration, | ||
| this.reverseDuration, | ||
| required this.vsync, | ||
| // This field is now ignored and will be deprecated. |
There was a problem hiding this comment.
Can you phrase this as a "TODO(xx): deprecate when customer tests are updated"?
This fixes a memory leak in which RenderAnimatedSize instances were creating tickers in the TickerProvider but were not disposing them.
jason-simmons
force-pushed
the
animated_size_leak_2
branch
from
b44fa03
to
13aacfc
Compare
jason-simmons
added a commit
to flutter/gallery
that referenced
this pull request
Apr 22, 2021
This is needed in order to land flutter/flutter#80554, which will deprecate AnimatedSize.vsync
Hixie
pushed a commit
to jocosocial/rainbowmonkey
that referenced
this pull request
Apr 22, 2021
This is needed in order to land flutter/flutter#80554, which will deprecate AnimatedSize.vsync
renyou
pushed a commit
to renyou/flutter
that referenced
this pull request
Apr 26, 2021
renyou
added a commit
that referenced
this pull request
Apr 26, 2021
…81076 (#81155) * Revert "Replace some `dynamic` to `Object?` type (#80772)" (#80965) This reverts commit 12a2e68. * Add frontend_server_client to dependency allowlist (#80912) * Revert "[RenderEditable] Dont paint caret when selection is invalid (#79607)" (#81076) This reverts commit 0f8148e. * Convert AnimatedSize to a StatefulWidget (#80554) Co-authored-by: Jenn Magder <magder@google.com> Co-authored-by: Jason Simmons <jason-simmons@users.noreply.github.com>
topdeveloper-dev
pushed a commit
to topdeveloper-dev/gallery
that referenced
this pull request
Mar 20, 2023
This is needed in order to land flutter/flutter#80554, which will deprecate AnimatedSize.vsync
Seven-112
pushed a commit
to Seven-112/gallery
that referenced
this pull request
May 16, 2023
This is needed in order to land flutter/flutter#80554, which will deprecate AnimatedSize.vsync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a memory leak in which RenderAnimatedSize instances were
creating tickers in the TickerProvider but were not disposing them.