Fix Hit Tests in RenderEditable when Scrolled #81040
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
hitTestChildren
inRenderEditable
by respecting the scrolloffset
(_paintOffset
for applying the scroll axis).Before, hit tests were broken when the
EditableText
/TextField
was scrolled.Issues
Fixes #81038.
Tests
The first test case I added was passing before (making sure that my change does not make that fail) and the latter two test cases were failing before.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.