Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Improve performance of debugCheckHasDirectionality" #81409

Merged
merged 1 commit into from Apr 28, 2021

Conversation

renyou
Copy link
Contributor

@renyou renyou commented Apr 28, 2021

Reverts #81250

Internal test failure: test/OCL:370782196:BASE:370941740:1619633912541:9bf6c1ce

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 28, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@renyou renyou requested a review from Hixie April 28, 2021 18:50
@google-cla google-cla bot added the cla: yes label Apr 28, 2021
@renyou renyou merged commit 99f19d0 into master Apr 28, 2021
@renyou renyou deleted the revert-81250-assert2 branch April 28, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant