[integration_test] Don't log exceptions twice #81812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
team
dnfield
reviewed
May 4, 2021
| The test description was: Exception handling in test harness - uncaught Future error | ||
| .*(TODO\(jiahaog\): Remove the next line once https://github.com/flutter/flutter/issues/81521 is fixed)? |
There was a problem hiding this comment.
I'm correctly understanding this as effectively a comment in this file, not actually matching output right/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, exceptions thrown in integration tests are logged twice. This is confusing for users, who might mistakenly believe that the tests are running twice.
Please see the comment in the diff for more details. For tests, I removed some of the
<<skip until matching line>>markers from the stack trace golden to make it stricter.Also relevant: #7669