Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable ideographic script test on web #83130

Merged
merged 1 commit into from May 22, 2021
Merged

disable ideographic script test on web #83130

merged 1 commit into from May 22, 2021

Conversation

yjbanov
Copy link
Contributor

@yjbanov yjbanov commented May 21, 2021

The ahem.ttf font we use lacks Chinese glyphs, which makes the test sensitive to the browser/OS it's running on. Disabling the test to unblock the HHH bot until we find a solution.

Filed #83129 to follow-up.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label May 21, 2021
@google-cla google-cla bot added the cla: yes label May 21, 2021
sigmundch
sigmundch approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@sigmundch sigmundch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

GaryQian
GaryQian approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Ahem is very basic and shouldnt really be expected to support anything advanced. If I remember correctly, I created a test font called 'cough' at some point to address some of ahem's limitations.

@GaryQian
Copy link
Contributor

flutter/engine#13649 This is the PR that adds Cough, which we can add whatever glyphs we want.

@yjbanov yjbanov merged commit a05076e into flutter:master May 22, 2021
@yjbanov
Copy link
Contributor Author

yjbanov commented May 22, 2021

flutter/engine#13649 This is the PR that adds Cough, which we can add whatever glyphs we want.

Thanks for the pointer. We can't use the C++ version of "Cough" directly, so I'll need a Dart copy of it.

@sigmundch sigmundch mentioned this pull request Aug 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaryQian GaryQian GaryQian approved these changes

@sigmundch sigmundch sigmundch approved these changes

Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yjbanov @GaryQian @sigmundch