Clean up NestedScrollView TODOs #84594
Conversation
Piinks
added
team
flutter-dashboard
bot
added
the
framework
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: only affects comments |
| @@ -341,7 +341,7 @@ typedef NestedScrollViewHeaderSliversBuilder = List<Widget> Function(BuildContex | |||
| /// | |||
| /// ### Stretching [SliverAppBar]s | |||
| /// | |||
| // TODO(Piinks): Support stretching, https://github.com/flutter/flutter/issues/54059 | |||
| // See https://github.com/flutter/flutter/issues/54059 | |||
There was a problem hiding this comment.
Is this something we do not want to fix in the future? I took a look at the original issue, I didn't see a concrete suggestion yet. Remove the todo here may make us overlook the issue.
There was a problem hiding this comment.
I wondered the same, but then I noticed above here on l#337 the same convention was being used. Since there is an active issue I didn't know if this was worth being tallied as part of our tech debt benchmark, when really the intention is to provide context/reference for whomever works on resolving the issue.
There was a problem hiding this comment.
i think if the issue is worth mentioning, and it's an action item that we should definitely take, then it is by definition a TODO. I wouldn't worry about whether it affects the benchmark or not. Just fiddling the numbers doesn't help concretely. :-)
This cleans up two TODOs in
nested_scroll_view.dartThese 2 todos both reference the same active issue (#54059). I don't feel that we need to be tracking this active issue as part of our technical debt benchmark. Left the link to the associated issue where it is referenced in the docs.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.