Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with overflow exceptions with nested lists inside a reorderable list item. #84828

Merged

Conversation

darrenaustin
Copy link
Contributor

Fixes #83224.

The issue is caused by the nested list picking up the outer scaffold top padding when it is moved to the overlay. The parent ReorderableList normally deals with that so that any nested list views won't see the padding. However, when the item is moved to the overlay, it is now a top level list and picks up the padding which causes it to overflow the size of the list item. This PR fixes this by removing any top padding from the MediaQueryData that wraps the child.

Added a new test to ensure this doesn't break again.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jun 18, 2021
@google-cla google-cla bot added the cla: yes label Jun 18, 2021
@Piinks Piinks added f: scrolling Viewports, list views, slivers, etc. c: regression It was better in the past than it is now labels Jun 18, 2021
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: regression It was better in the past than it is now f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReorderableListView throws RenderFlex exception while dragging on latest stable and master
3 participants