Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borderRadius param updated in copyWith functions #85822

Merged
merged 5 commits into from Jul 12, 2021

Conversation

payam-zahedi
Copy link
Contributor

@payam-zahedi payam-zahedi commented Jul 3, 2021

Update the BorderRadius parameter and change it with BorderRadiusGeometry in copyWith method of OutlinedBorder subclasses.

Fixes #70313

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 3, 2021
@google-cla google-cla bot added the cla: yes label Jul 3, 2021
@payam-zahedi
Copy link
Contributor Author

Hi @Piinks, I hope you're doing well.
I re-created my last PR, you can find the last one here #70585
in this PR, I updated the copyWith function of the OutlinedBorder subclasses, and added some test for each of them.

@Piinks Piinks self-requested a review July 7, 2021 16:30
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thank you for returning and finishing this contribution! 🎉

@Piinks
Copy link
Contributor

Piinks commented Jul 8, 2021

Can you update your branch with the latest from master? I think that should resolve the failing check here due to an infra issue.

@payam-zahedi
Copy link
Contributor Author

payam-zahedi commented Jul 10, 2021

@Piinks thanks for reviewing my PR. All the checks have been passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RoundedRectangleBorder.copyWith takes a BorderRadius rather than the constructors BorderRadiusGeometry
3 participants