New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
borderRadius param updated in copyWith functions #85822
borderRadius param updated in copyWith functions #85822
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
0e8c912
to
796eb6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! Thank you for returning and finishing this contribution! 🎉
Can you update your branch with the latest from master? I think that should resolve the failing check here due to an infra issue. |
…te-border-radius
@Piinks thanks for reviewing my PR. All the checks have been passed. |
Update the BorderRadius parameter and change it with BorderRadiusGeometry in copyWith method of OutlinedBorder subclasses.
Fixes #70313
Pre-launch Checklist
///
).