Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added autofocus property to CupertinoSearchTextField #87591

Merged
merged 1 commit into from Aug 4, 2021
Merged

Added autofocus property to CupertinoSearchTextField #87591

merged 1 commit into from Aug 4, 2021

Conversation

werainkhatri
Copy link
Member

The CupertinoSearchTextField lacked the autofocus property.

fixes #87453

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Aug 3, 2021
@google-cla google-cla bot added the cla: yes label Aug 3, 2021
LongCatIsLooong
LongCatIsLooong approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

@fluttergithubbot fluttergithubbot merged commit f134f03 into flutter:master Aug 4, 2021
@werainkhatri werainkhatri deleted the cstf-autofocus branch August 4, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

Assignees
No one assigned
Labels
f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add property autofocus to CupertinoSearchTextField
3 participants
@werainkhatri @LongCatIsLooong @fluttergithubbot