Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate fuchsia sdk and dependencies to null safety #88920

Merged
merged 1 commit into from Aug 26, 2021
Merged

Migrate fuchsia sdk and dependencies to null safety #88920

merged 1 commit into from Aug 26, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Aug 26, 2021

Part of #71511

@jmagman jmagman added tool Affects the "flutter" command-line tool. See also t: labels. a: null-safety Support for the Dart's team new null safety feature labels Aug 26, 2021
@jmagman jmagman self-assigned this Aug 26, 2021
@google-cla google-cla bot added the cla: yes label Aug 26, 2021
jmagman
jmagman commented Aug 26, 2021
View reviewed changes
packages/flutter_tools/lib/src/fuchsia/fuchsia_kernel_compiler.dart
@@ -64,8 +62,12 @@ class FuchsiaKernelCompiler {
'$multiRootScheme:///$target',
];

final String? engineDartBinaryPath = globals.artifacts?.getHostArtifact(HostArtifact.engineDartBinary).path;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is new.

@jmagman jmagman requested a review from zanderso August 26, 2021 01:23
jmagman
jmagman commented Aug 26, 2021
View reviewed changes
packages/flutter_tools/lib/src/fuchsia/fuchsia_sdk.dart
@@ -32,26 +30,20 @@ bool isFuchsiaSupportedPlatform(Platform platform) {
/// including a working fx command-line tool in the user's PATH.
class FuchsiaSdk {
/// Interface to the 'pm' tool.
FuchsiaPM get fuchsiaPM => _fuchsiaPM ??= FuchsiaPM();
FuchsiaPM _fuchsiaPM;
late final FuchsiaPM fuchsiaPM = FuchsiaPM();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ooo pretty)

@fluttergithubbot fluttergithubbot merged commit 0cb6d59 into flutter:master Aug 26, 2021
@jmagman jmagman deleted the null-fuchsia branch August 26, 2021 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

Assignees

@jmagman jmagman

Labels
a: null-safety Support for the Dart's team new null safety feature tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmagman @zanderso @fluttergithubbot