Close the IntegrationTestTestDevice stream when the VM service shuts down #90022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
jiahaog
approved these changes
Sep 14, 2021
Comment on lines
+104
to
+106
| unawaited(vmService.service.onDone.whenComplete( | ||
| () => controller.local.sink.close(), | ||
| )); |
There was a problem hiding this comment.
nit: Can this be merged into the remoteMessages.listen above?
remoteMessages.listen(
(String s) => controller.local.sink.add(s),
onError: (Object error, StackTrace stack) => controller.local.sink.addError(error, stack),
onDone: () => controller.local.sink.close(),
);There was a problem hiding this comment.
The remoteMessages stream is not closed when the on-device process crashes.
That event appears to be signaled only by the VM service's onDone.
jason-simmons
force-pushed
the
bug_89829
branch
from
b8825aa
to
20ed813
Compare
jason-simmons
force-pushed
the
bug_89829
branch
from
20ed813
to
d053abc
Compare
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89829