Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align both reflectly-hero & dart-diagram to the center. #90060

Merged
merged 1 commit into from Sep 20, 2021
Merged

Align both reflectly-hero & dart-diagram to the center. #90060

merged 1 commit into from Sep 20, 2021

Conversation

Pradumnasaraf
Copy link
Contributor

Aligned both reflectly-hero & dart-diagram to the center, so that it can look aligned w.r.t first image (Flutter logo) in README.md and also follow a similar pattern.

Before Changes

Before Changes

After Changes

After Changes

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Sep 14, 2021
@Pradumnasaraf
Copy link
Contributor Author

Please see to this PR :).@justinmc @kjlubick @Piinks @dnfield.

justinmc
justinmc reviewed Sep 15, 2021
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick improvement! Looks better to me.

I think we'll need an exemption for no tests, I'll post on Discord.

README.md Outdated
@@ -36,7 +36,7 @@ graphics, video, text, and controls without limitation. Flutter includes a full
[set of widgets][widget catalog] that deliver pixel-perfect experiences on both
iOS and Android.

![Reflectly hero image][Reflectly hero image]
<p align = "center"><img src="https://github.com/flutter/website/blob/main/src/assets/images/docs/homepage/reflectly-hero-600px.png?raw=true"></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the alt text? alt="Reflectly hero image"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also nit:

- align = "center"
+ align="center"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinmc Done

<p align="center"><img src="https://github.com/flutter/website/blob/main/src/assets/images/docs/homepage/reflectly-hero-600px.png?raw=true" alt="Reflectly hero image"></p>

<p align="center"><img src="https://github.com/flutter/website/blob/main/src/assets/images/docs/homepage/dart-diagram-small.png?raw=true" alt="Dart diagram"></p>

README.md
@@ -36,7 +36,7 @@ graphics, video, text, and controls without limitation. Flutter includes a full
[set of widgets][widget catalog] that deliver pixel-perfect experiences on both
iOS and Android.

![Reflectly hero image][Reflectly hero image]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still possible to use the reference to Reflectly hero image in the src attribute? Maybe not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we can't use it in that way

@Hixie
Copy link
Contributor

Hixie commented Sep 15, 2021

test-exempt: only affects markdown

@goderbauer goderbauer added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Sep 15, 2021
@Pradumnasaraf
Copy link
Contributor Author

Pradumnasaraf commented Sep 16, 2021 •
edited

@justinmc Done, added alt= "Reflectly hero image" & alt="Dart diagram" and nit

<p align="center"><img src="https://github.com/flutter/website/blob/main/src/assets/images/docs/homepage/reflectly-hero-600px.png?raw=true" alt="Reflectly hero image"></p>

<p align="center"><img src="https://github.com/flutter/website/blob/main/src/assets/images/docs/homepage/dart-diagram-small.png?raw=true" alt="Dart diagram"></p>

@Piinks Piinks mentioned this pull request Sep 17, 2021
Merged
@Pradumnasaraf
Copy link
Contributor Author

Sorry to ping you, @Piinks, @goderbauer, @justinmc if everything is okay please merge 😀

@Piinks
Copy link
Contributor

Piinks commented Sep 20, 2021

Sorry to ping you, @Piinks, @goderbauer, @justinmc if everything is okay please merge 😀

It has not been approved yet, @Pradumnasaraf, that is probably why. :)

Piinks
Piinks approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@fluttergithubbot fluttergithubbot merged commit f04b266 into flutter:master Sep 20, 2021
@Pradumnasaraf Pradumnasaraf deleted the Image-Align branch September 20, 2021 16:56
@Pradumnasaraf Pradumnasaraf mentioned this pull request Sep 21, 2021
Merged
8 tasks
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@Pradumnasaraf @clocksmith
Align both reflectly-hero & dart-diagram to the center. (flutter#90060)
0f4f5de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc left review comments

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Pradumnasaraf @Hixie @Piinks @justinmc @goderbauer @fluttergithubbot