Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BottomNavigationBarItem.title deprecation #90295

Merged
merged 4 commits into from
Oct 14, 2021

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Sep 17, 2021

This removes the title parameter from BottomNavigationBarItem.

The replacement for which is to use label instead. This is supported by dart fix.

This deprecations has expired, as laid out in flutter.dev/go/deprecations-removed-after-2-5

Part of #90287

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. framework flutter/packages/flutter repository. See also f: labels. c: API break Backwards-incompatible API changes c: tech-debt Technical debt, code quality, testing, etc. labels Sep 17, 2021
@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. labels Sep 17, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Sep 17, 2021
@Piinks
Copy link
Contributor Author

Piinks commented Sep 22, 2021

@HansMuller can you consult on the new API? I am not sure if label should be required now.

Update: It should not be required because the Cupertino tab bar does not require it, it has a test verifying this. The material BottomNavigationBar asserts that the BottomNavigationBarItems do have a label, so it is all covered.

@Piinks Piinks changed the title [WIP] Remove BottomNavigationBarItem.title deprecation Remove BottomNavigationBarItem.title deprecation Sep 30, 2021
@Piinks
Copy link
Contributor Author

Piinks commented Sep 30, 2021

Just waiting on an internal change to land, there were some lingering dart doc references.

@Piinks
Copy link
Contributor Author

Piinks commented Oct 6, 2021

Customers are migrated, this can land now.

@Piinks
Copy link
Contributor Author

Piinks commented Oct 6, 2021

@goderbauer can you approve this now that everyone is migrated?

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: API break Backwards-incompatible API changes c: tech-debt Technical debt, code quality, testing, etc. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants