-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove BottomNavigationBarItem.title deprecation #90295
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
@HansMuller can you consult on the new API? Update: It should not be required because the Cupertino tab bar does not require it, it has a test verifying this. The material BottomNavigationBar asserts that the BottomNavigationBarItems do have a label, so it is all covered. |
Just waiting on an internal change to land, there were some lingering dart doc references. |
Customers are migrated, this can land now. |
@goderbauer can you approve this now that everyone is migrated? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This removes the
title
parameter fromBottomNavigationBarItem
.The replacement for which is to use label instead. This is supported by dart fix.
This deprecations has expired, as laid out in flutter.dev/go/deprecations-removed-after-2-5
Part of #90287
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.