Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable only_throw_errors #91567

Merged
merged 1 commit into from Oct 11, 2021
Merged

Enable only_throw_errors #91567

merged 1 commit into from Oct 11, 2021

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Oct 10, 2021

Fixes #5792

I decided to not attempt to port flutter_test to a world with exception objects, and I exempted the dev directory and some test directories that make extensive use of the "throw string" pattern. The idea here is mostly to prevent us from violating this in the framework, that's where it matters most.

@Hixie Hixie requested a review from Piinks as a code owner October 10, 2021 00:38
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 10, 2021
@google-cla google-cla bot added the cla: yes label Oct 10, 2021
@Hixie
Copy link
Contributor Author

Hixie commented Oct 10, 2021

cc @goderbauer

goderbauer
goderbauer approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie Hixie mentioned this pull request Oct 11, 2021
Closed
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • This commit is not mergeable and has conflicts. Please rebase your PR and fix all the conflicts.

@fluttergithubbot fluttergithubbot merged commit 9421627 into flutter:master Oct 11, 2021
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@Hixie @clocksmith
Enable only_throw_errors (flutter#91567)
7f626e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@Piinks Piinks Awaiting requested review from Piinks

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable only_throw_errors analysis option
3 participants
@Hixie @fluttergithubbot @goderbauer