Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable sort_child_properties_last lint #91585

Merged
merged 1 commit into from Oct 12, 2021
Merged

Enable sort_child_properties_last lint #91585

merged 1 commit into from Oct 12, 2021

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Oct 10, 2021

No description provided.

@flutter-dashboard flutter-dashboard bot added a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Oct 10, 2021
@google-cla google-cla bot added the cla: yes label Oct 10, 2021
@Hixie
Copy link
Contributor Author

Hixie commented Oct 10, 2021

cc @goderbauer for framework
cc @gspencergoog for examples

Zazo032
Zazo032 reviewed Oct 11, 2021
View reviewed changes
examples/api/lib/widgets/basic/physical_shape.0.dart Outdated
Comment on lines 37 to 40
clipper: ShapeBorderClipper(
shape: RoundedRectangleBorder(
borderRadius: BorderRadius.circular(10.0),
)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
clipper: ShapeBorderClipper(
shape: RoundedRectangleBorder(
borderRadius: BorderRadius.circular(10.0),
)),
clipper: ShapeBorderClipper(
shape: RoundedRectangleBorder(
borderRadius: BorderRadius.circular(10.0),
),
),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! will fix

dev/integration_tests/deferred_components_test/lib/component1.dart Outdated
@@ -16,14 +16,14 @@ class LogoScreen extends StatelessWidget {
Widget build(BuildContext context) {
print(_testSentinel);
return Container(
padding: const EdgeInsets.all(25),
color: Colors.blue,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
color: Colors.blue,
color: Colors.blue,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zazo032 thanks for your excellent code review, I totally missed both of those.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're welcome 🙂

goderbauer
goderbauer approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Hixie
Copy link
Contributor Author

Hixie commented Oct 12, 2021

Google testing failure is because the roll is so far behind this conflicts with other changes.

@fluttergithubbot fluttergithubbot merged commit 6d5fc42 into flutter:master Oct 12, 2021
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@Hixie @clocksmith
Enable sort_child_properties_last lint (flutter#91585)
87d4622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zazo032 Zazo032 Zazo032 left review comments

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Hixie @fluttergithubbot @goderbauer @Zazo032