Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate build_system targets to null safety #92869

Merged
merged 1 commit into from Nov 18, 2021
Merged

Migrate build_system targets to null safety #92869

merged 1 commit into from Nov 18, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Nov 2, 2021

Migrate the last null unsafe build_system targets.

Part of #71511.

@jmagman jmagman added tool Affects the "flutter" command-line tool. See also t: labels. a: null-safety Support for the Dart's team new null safety feature c: tech-debt Technical debt, code quality, testing, etc. labels Nov 2, 2021
@jmagman jmagman self-assigned this Nov 2, 2021
@google-cla google-cla bot added the cla: yes label Nov 2, 2021
@jmagman jmagman mentioned this pull request Nov 2, 2021
Closed
christopherfujino
christopherfujino approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member Author

jmagman commented Nov 5, 2021

Google testing failing because #93002 has not yet rolled.

@jmagman
Copy link
Member Author

jmagman commented Nov 17, 2021

Rebased onto #93556.

@fluttergithubbot fluttergithubbot merged commit e56c83a into flutter:master Nov 18, 2021
@jmagman jmagman deleted the migrate-deferred branch November 18, 2021 20:58
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
@jmagman @WizzXu
Migrate build_system targets to null safety (flutter#92869)
f958405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees

@jmagman jmagman

Labels
a: null-safety Support for the Dart's team new null safety feature c: tech-debt Technical debt, code quality, testing, etc. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmagman @christopherfujino @fluttergithubbot