New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DAP] Add a custom event to pass flutter.serviceExtensionStateChanged… #93870
[DAP] Add a custom event to pass flutter.serviceExtensionStateChanged… #93870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This pull request is not suitable for automatic merging in its current state.
|
Gold has detected about 1 new digest(s) on patchset 1. |
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. Changes reported for pull request #93870 at sha 8571500713d71fcc9a32eff851d7f02443f9551f |
@christopherfujino I'm not sure how to interpret the above. It looks like the golden for |
Ah, got it - I've rebased. I'm not sure if I need to remove the will-affect-goldens tag though - feel free to remove if it it shouldn't be on here (and the bot won't fix it). Thanks! |
This pull request is not suitable for automatic merging in its current state.
|
I think this failure is unrelated too.
|
… events back to the editor
😅 |
Rebasing again seems to have resolved that one :-) Hoping this will land once "Google testing" completes (which has been going a while, but I don't know how long it normally takes) |
This exposes a custom event (
flutter.serviceExtensionStateChanged
) through DAP. This allows an editor to know when service extension state is changing (would could be as a result of another editor, or a DevTools instance changing it).VS Code uses this to know know things like whether the app is in "select widget mode" so it can provide the correct toggle command.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.