Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAP] Add a custom event to pass flutter.serviceExtensionStateChanged… #93870

Merged
merged 1 commit into from Nov 23, 2021
Merged

[DAP] Add a custom event to pass flutter.serviceExtensionStateChanged… #93870

merged 1 commit into from Nov 23, 2021

Conversation

DanTup
Copy link
Contributor

@DanTup DanTup commented Nov 18, 2021

This exposes a custom event (flutter.serviceExtensionStateChanged) through DAP. This allows an editor to know when service extension state is changing (would could be as a result of another editor, or a DevTools instance changing it).

VS Code uses this to know know things like whether the app is in "select widget mode" so it can provide the correct toggle command.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 18, 2021
@google-cla google-cla bot added the cla: yes label Nov 18, 2021
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • This commit is not mergeable and has conflicts. Please rebase your PR and fix all the conflicts.

@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/93870

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #93870 at sha 8571500713d71fcc9a32eff851d7f02443f9551f

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Nov 19, 2021
@DanTup
Copy link
Contributor Author

DanTup commented Nov 19, 2021

@christopherfujino I'm not sure how to interpret the above. It looks like the golden for material.input_decorator.outline_label.rtl mismatched, but I don't expect this change to alter any rendering at all.

@christopherfujino
Copy link
Member

@DanTup Looks like this was "fixed" upstream in #93925. I'm pretty sure rebasing past that will fix it.

@DanTup
Copy link
Contributor Author

DanTup commented Nov 20, 2021

Ah, got it - I've rebased. I'm not sure if I need to remove the will-affect-goldens tag though - feel free to remove if it it shouldn't be on here (and the bot won't fix it). Thanks!

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux android views has failed. Please fix the issues identified (or deflake) before re-applying this label.

@DanTup
Copy link
Contributor Author

DanTup commented Nov 20, 2021

I think this failure is unrelated too.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8830048478477663297/+/u/Android_Views_Integration_Tests/stdout

Downloading linux-x64/linux-x64-flutter-gtk tools...             1,732ms
Downloading linux-x64-profile/linux-x64-flutter-gtk tools...        667ms
Downloading linux-x64-release/linux-x64-flutter-gtk tools...        456ms
Running "flutter pub get" in android_views...                       3.1s
No Linux desktop project configured. See https://flutter.dev/desktop#add-desktop-support-to-an-existing-flutter-app to learn about adding Linux support to a project.

@DanTup DanTup added waiting for tree to go green and removed will affect goldens Changes to golden files labels Nov 22, 2021
@christopherfujino
Copy link
Member

I think this failure is unrelated too.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8830048478477663297/+/u/Android_Views_Integration_Tests/stdout

Downloading linux-x64/linux-x64-flutter-gtk tools...             1,732ms
Downloading linux-x64-profile/linux-x64-flutter-gtk tools...        667ms
Downloading linux-x64-release/linux-x64-flutter-gtk tools...        456ms
Running "flutter pub get" in android_views...                       3.1s
No Linux desktop project configured. See https://flutter.dev/desktop#add-desktop-support-to-an-existing-flutter-app to learn about adding Linux support to a project.

😅

@DanTup
Copy link
Contributor Author

DanTup commented Nov 22, 2021

Rebasing again seems to have resolved that one :-) Hoping this will land once "Google testing" completes (which has been going a while, but I don't know how long it normally takes)

@fluttergithubbot fluttergithubbot merged commit 77fca35 into flutter:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants