Corrected a ChipTheme labelStyle corner case #94818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
gspencergoog
reviewed
Dec 7, 2021
| ?? theme.chipTheme.labelStyle; | ||
| final TextStyle labelStyle = chipTheme.labelStyle | ||
| ?? theme.chipTheme.labelStyle | ||
| ?? chipDefaults.labelStyle!; |
There was a problem hiding this comment.
When can this be null?
There was a problem hiding this comment.
ChipThemeData is now like the other theme data classes: all properties are null by default. You set them to override the default that's computed by the component.
The value of chipDefaults.labelStyle! can't be null ofcourse, chipDefaults is the internal representation of the default values for most properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the theme's ChipTheme is defined with a TextStyle with
inherit:true(the default), theDefaultTextStyle.stylethat wraps the label widget should also beinherit:true. The ChipTheme merge had been set up incorrectly and so this wasn't happening. It wasn't particularly noticeable because the default labelStyle hasinherit:false.